Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve #334

Open
wants to merge 70 commits into
base: dev
Choose a base branch
from
Open

Improve #334

wants to merge 70 commits into from

Conversation

jaiwiwjwjwisn
Copy link

No description provided.

@fabclmnt
Copy link
Contributor

fabclmnt commented May 6, 2024

HI @jaiwiwjwjwisn ,
thank you for you PR. Given the extend of your changes can I suggest that you do different PR for each one of them so it eases the process of review?

eg:

  • feat: add inverse transformation logic
  • feat: Update package version
  • chores: Update gitignore & example

Also, please follow the naming and convention for the PRs so we can automatically calculate the package version (examples provided above.)

Looking forward to integrate your developments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants